> On Aug. 16, 2013, 12:56 a.m., Alessandro Presta wrote: > > findbugs-exclude.xml, line 21 > > <https://reviews.apache.org/r/13447/diff/1/?file=339300#file339300line21> > > > > What's the point of leaving these in a comment?
no point, removing. - Nitay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13447/#review25225 ----------------------------------------------------------- On Aug. 9, 2013, 8:50 p.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13447/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 8:50 p.m.) > > > Review request for giraph. > > > Bugs: GIRAPH-736 > https://issues.apache.org/jira/browse/GIRAPH-736 > > > Repository: giraph-git > > > Description > ------- > > Bring back FindBugs > > > Diffs > ----- > > findbugs-exclude.xml 6cc5f7a92e0e9163257bba98b939671c56adb788 > giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java > 42e8e7ee4a33865aaa6e5bab3a6f657ce40957cd > > giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/SequentialFileMessageStore.java > 89520ffad362b9559bd7f239647d8683a9c69532 > giraph-core/src/main/java/org/apache/giraph/comm/netty/SaslNettyServer.java > 2cbf4820ef83e591b54e21e34cc7b9b8be6880e3 > > giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java > a02039e8f395a6ca1925d66e2b3316c8e32ef422 > > giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/ResponseClientHandler.java > 9f3f0344bf8d27a4ba7da16cebbe5e4df0e72ad4 > > giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/SaslServerHandler.java > 9644a5f1ce51e9e658ce7bb6fa31a910d3532aec > giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java > 1f9fb78a07d97cedf1bfb4628d976e4e57d4d6c9 > > giraph-core/src/main/java/org/apache/giraph/jython/wrappers/JythonWrapperBase.java > 4ec450a80a03ced8bc388d06a66b8514ede22276 > > giraph-core/src/main/java/org/apache/giraph/jython/wrappers/JythonWritableWrapper.java > 478863472740d8860f550b456d42de2258152a59 > giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java > d08495ba4ef03a36052ad5a48d4c129a500cbd2c > > giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java > dbfb7916f0083e18b55ed8bca402305bc23916ff > > giraph-core/src/main/java/org/apache/giraph/partition/PartitionBalancer.java > 2befa9c61af3fc97d60f44f4d29886e39c1ccdcb > giraph-core/src/main/java/org/apache/giraph/partition/PartitionUtils.java > fc75006d8e40e1e1d99220465186f3f4030fa776 > giraph-core/src/main/java/org/apache/giraph/utils/EdgeComparator.java > df40f01db136e4fb080cf051fb79878d56937ae3 > giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java > 1bc11a81c36f70ceb6bb5e3124bc2e1763612bc1 > giraph-core/src/main/java/org/apache/giraph/utils/JMap.java > 69d1ab320ce1273f75800f7404c16f63085c9259 > giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java > da1e7fbc57fd220cf324dd21bf871323a7d375f4 > giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java > 7a374b17a1d9eb86ddeccc0d8e06c280cc1bb1ff > > giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkWorkerContext.java > 5c23b5a55d7551c9c89011282d69904875c49816 > > giraph-examples/src/main/java/org/apache/giraph/examples/SimpleAggregatorWriter.java > b019b40e912470c48a4cdf9ef3111f36ed9527f4 > > giraph-examples/src/main/java/org/apache/giraph/examples/SimpleCheckpoint.java > 984e0792b10a9d84b5f6da71c9cf12c4b78a9a84 > > giraph-examples/src/main/java/org/apache/giraph/examples/SimpleFailComputation.java > 15829021c97ef093284881ba53da7a9ba60a5297 > > giraph-examples/src/main/java/org/apache/giraph/examples/SimpleMasterComputeComputation.java > b9b2373944e3f09cc816320d139f70350b207d08 > > giraph-examples/src/main/java/org/apache/giraph/examples/SimpleTriangleClosingComputation.java > 8608d028bb67bdb6ae4236543c0e8ed60e6520a9 > > giraph-rexster/src/main/java/org/apache/giraph/rexster/utils/RexsterUtils.java > 23c9b58f3ec51eaa595247d1a5cda4214c150410 > > Diff: https://reviews.apache.org/r/13447/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
