----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13399/#review25462 -----------------------------------------------------------
This looks good to be, but I am not that familiar with the YARN code. Eli, any comments? - Avery Ching On Aug. 8, 2013, 1:52 a.m., Chuan Lei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13399/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 1:52 a.m.) > > > Review request for giraph and Avery Ching. > > > Bugs: GIRAPH-730 > https://issues.apache.org/jira/browse/GIRAPH-730 > > > Repository: giraph-git > > > Description > ------- > > In GiraphApplicationMaster.java, getTaskResourceMap function is not > multi-thread safe, which causes the application master fail to distribute the > resources (jar, configuration file, etc.) to each container. > > > Diffs > ----- > > > giraph-core/src/main/java/org/apache/giraph/yarn/GiraphApplicationMaster.java > c2b88a0 > > Diff: https://reviews.apache.org/r/13399/diff/ > > > Testing > ------- > > > Thanks, > > Chuan Lei > >
