----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14585/#review26916 -----------------------------------------------------------
Ship it! +1, thanks for this! giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java <https://reviews.apache.org/r/14585/#comment52395> reading from an in-memory... - Avery Ching On Oct. 11, 2013, 12:17 a.m., Maja Kabiljo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14585/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 12:17 a.m.) > > > Review request for giraph. > > > Bugs: GIRAPH-778 > https://issues.apache.org/jira/browse/GIRAPH-778 > > > Repository: giraph-git > > > Description > ------- > > TestGraph was never really working correctly, since for example newly created > vertices wouldn't be a part of it, deleted vertices would still be there, it > won't work with ByteArrayPartition... But after GIRAPH-775 it's completely > useless since all vertices from input format are serialized and deserialized > to other objects. > I added InMemoryVertexOutputFormat which stores all vertices in its static > field TestGraph. Now when running InternalVertexRunner.runWithInMemoryOutput > all vertices will be stored to this TestGraph. > > > Diffs > ----- > > > giraph-core/src/main/java/org/apache/giraph/bsp/ImmutableOutputCommitter.java > e5480cc > > giraph-core/src/main/java/org/apache/giraph/io/formats/InMemoryVertexOutputFormat.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java > 72fab83 > giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java 312a287 > giraph-core/src/test/java/org/apache/giraph/master/TestSwitchClasses.java > e96fd12 > > giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsComputationTestInMemory.java > 1bb8e94 > > Diff: https://reviews.apache.org/r/14585/diff/ > > > Testing > ------- > > mvn clean verify > > I don't understand why, but when we all tests together nothing fails, however > with current code running ConnectedComponentsComputationTestInMemory > separately fails. With this patch it succeeds. > > > Thanks, > > Maja Kabiljo > >
