----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14588/#review26922 -----------------------------------------------------------
Ship it! +1, nice! - Avery Ching On Oct. 11, 2013, 3:13 a.m., Maja Kabiljo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14588/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 3:13 a.m.) > > > Review request for giraph. > > > Bugs: GIRAPH-779 > https://issues.apache.org/jira/browse/GIRAPH-779 > > > Repository: giraph-git > > > Description > ------- > > Reusing objects helps us keep GC under control, we should provide an easy way > to reuse them during input. > Added instances of ids/values to SImpleHiveToVertex and SimpleHiveToEdge, and > modify example HiveTo* classes to reuse objects. > > > Diffs > ----- > > giraph-hive/pom.xml daa08b3 > giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveParsing.java > 56f5119 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/SimpleHiveToEdge.java > c365a87 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/examples/HiveIntDoubleEdge.java > 9f95da2 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/examples/HiveIntNullEdge.java > 87e1bd5 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleHiveToVertex.java > 5483a68 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/examples/HiveIntDoubleDoubleVertex.java > 1af01d4 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/examples/HiveIntIntNullVertex.java > cc61441 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/examples/HiveIntNullNullVertex.java > 02ad6a1 > > giraph-hive/src/main/java/org/apache/giraph/hive/jython/JythonHiveToEdge.java > c541232 > > giraph-hive/src/main/java/org/apache/giraph/hive/jython/JythonHiveToVertex.java > f449ec5 > > Diff: https://reviews.apache.org/r/14588/diff/ > > > Testing > ------- > > mvn clean verify > > > Thanks, > > Maja Kabiljo > >
