-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15188/#review28041
-----------------------------------------------------------

Ship it!


+1, this is great.

- Avery Ching


On Nov. 1, 2013, 9:48 p.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15188/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 9:48 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Bugs: GIRAPH-790
>     https://issues.apache.org/jira/browse/GIRAPH-790
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> In some cases we want to be able to automatically retry a job.
> By default don't retry any jobs, but can set your own class to inspect 
> whether a job should be retried.
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 
> 4dee396 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 
> eb8eb21 
>   
> giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
>  6bb6c00 
>   
> giraph-core/src/main/java/org/apache/giraph/job/DefaultGiraphJobRetryChecker.java
>  PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java fca14ac 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphJobRetryChecker.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15188/diff/
> 
> 
> Testing
> -------
> 
> Tested on a cluster with a hook which retries preempted jobs.
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>

Reply via email to