----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15723/#review29311 -----------------------------------------------------------
Ship it! Awesome, +1! giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java <https://reviews.apache.org/r/15723/#comment56468> Can't wait to use this all over the place :-) - Maja Kabiljo On Nov. 20, 2013, 7:51 p.m., Avery Ching wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15723/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 7:51 p.m.) > > > Review request for giraph. > > > Bugs: GIRAPH-798 > https://issues.apache.org/jira/browse/GIRAPH-798 > > > Repository: giraph-git > > > Description > ------- > > We need to upgrade to Java 7, Java 6 is no longer supported and Java 7 > provides a lot of great new features. > Additionally, we have a mess of dependencies. > > Incompatible versions, unspecified dependencies, and duplicate classes. We > will add checks for all of them. > > For now, full checks are provided for the following profiles (other profiles > are not fully fixed yet) > hadoop_0.20.203 > hadoop_1.0 > hadoop_facebook > > Also, the hcatalog module is not fully fixed and excluded from the checking. > We can fix this in the future. > > Note that this is one very minor code change (BspServiceWorker.java) to prove > that Java 7 is being used. > > > Diffs > ----- > > giraph-accumulo/pom.xml 79782c1b6bcf2c543baccbe4847c8042cae7ec2b > giraph-core/pom.xml f5ed8677bff8a0c2bbe90b0aaad39d4f257ed558 > giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java > f6da6806967f6c251295d4c7fb057e0b1c6c64f9 > giraph-examples/pom.xml 84ca118ae28d34bed398231dea24ca0529b4402f > giraph-gora/pom.xml 4b9ca6f52482bcccb632d57ad05bf0829c322098 > giraph-hbase/pom.xml eeb42d7c45d398358b3bfbedfd38f9ca5276cfdb > giraph-hcatalog/pom.xml 2d415981fb17a86304f95387e5fe5a881b1e1ad8 > giraph-hive/pom.xml 7feb5107a945335177a8d40ba7abdfa605c92633 > giraph-rexster/pom.xml d060af9f31d79de5d7717302b959b465ff0403bf > pom.xml 4660f0a8ceed00b5536e4471ee983be651b17d25 > > Diff: https://reviews.apache.org/r/15723/diff/ > > > Testing > ------- > > mvn clean verify > mvn clean verify -Phadoop_facebook > ran page rank benchmark on a cluster > > > Thanks, > > Avery Ching > >
