-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17446/#review32968
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Schelter


On Jan. 28, 2014, 6:55 a.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17446/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Bugs: GIRAPH-831
>     https://issues.apache.org/jira/browse/GIRAPH-831
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> * Adds a new timeout for waiting for all done tasks - 
> WAIT_TASK_DONE_TIMEOUT_MS
> * Prints the workers that have not yet responded
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 
> e378147e782d9e0c32f91ad5ec65dc876e9b7bb7 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 
> aca0c1665765246ad18ff982df527cb599fdfc83 
>   giraph-core/src/main/java/org/apache/giraph/zk/ComputationDoneName.java 
> PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java 
> b3db28f8fdefcf776428d3400c858fee8a676a07 
>   giraph-core/src/test/java/org/apache/giraph/zk/ComputationDoneNameTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17446/diff/
> 
> 
> Testing
> -------
> 
> mvn clean verify
> Added a unittest for file name creation and parsing.
> 
> 
> Thanks,
> 
> Avery Ching
> 
>

Reply via email to