[ 
https://issues.apache.org/jira/browse/GIRAPH-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890413#comment-13890413
 ] 

Eugene Koontz commented on GIRAPH-839:
--------------------------------------

Hm, looks like the build failed because a test couldn't connect to ZooKeeper?

https://builds.apache.org/job/Giraph-trunk-Commit/1403/consoleText (warning: 
big output)

{code}
14/02/03 17:53:01 INFO zookeeper.ClientCnxn: Opening socket connection to 
server localhost/127.0.0.1:22182
14/02/03 17:53:01 WARN zookeeper.ClientCnxn: Session 0x143f8e19d350002 for 
server null, unexpected error, closing socket connection and attempting 
reconnect
java.net.ConnectException: Connection refused
        at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
        at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:708)
        at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1119)
14/02/03 17:53:02 INFO server.SessionTrackerImpl: SessionTrackerImpl exited 
loop!
{code}


> NettyWorkerAggregatorRequestProcessor tries to reuse request objects
> --------------------------------------------------------------------
>
>                 Key: GIRAPH-839
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-839
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Pavan Kumar
>            Assignee: Pavan Kumar
>         Attachments: GIRAPH-839.patch
>
>
> I was working on upgrading netty to 4.0.14.Final. It is mostly done, after 
> some polishing I will submit a patch for that soon.
> While working on the above, I discovered a bug in 
> NettyWorkerAggregatorRequestProcessor. The distributeAggregators method is 
> reusing SendAggregatorsToWorkerRequest objects, which is incorrect since each 
> task has a different task id & (potentially a different) request id. It does 
> not cause any problem with current netty but in the new version I guess due 
> to delayed serialization the object cannot be reused.
> Anyway, moving it inside the for loop does not cause any issues with current 
> netty as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to