> On May 8, 2014, 9:59 p.m., Pavan Kumar Athivarapu wrote: > > I am not sure if u wanted to include me - (perhaps name mismatch) > > if u want I can review this over weekend. > > > > glancing over this seems good - your comment is valid. we assume sorted [& > > also that partitions are consequtive]
partition numbers are ofcourse consequtive because of this code https://gist.github.com/anonymous/a74b2bcc97e72fd6eade in HashMasterGraph partitioner & afaik partition cannot be deleted. so holes are not possible. - Pavan Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21151/#review42543 ----------------------------------------------------------- On May 7, 2014, 10:33 a.m., Lukas Nalezenec wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21151/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 10:33 a.m.) > > > Review request for giraph, Avery Ching, Claudio Martella, Maja Kabiljo, pavan > kumar kolamuri, and Sebastian Schelter. > > > Repository: giraph-git > > > Description > ------- > > PartitionBalancer returns PartitionOwners in list in arbitrary order but both > Range and Hash partitioners are assuming that list is sorted by partitionId. > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java > 7ab291b > > giraph-core/src/main/java/org/apache/giraph/partition/HashWorkerPartitioner.java > d833895 > > giraph-core/src/main/java/org/apache/giraph/partition/PartitionBalancer.java > 3454d62 > > giraph-core/src/main/java/org/apache/giraph/partition/SimpleWorkerPartitioner.java > 600d7a3 > > Diff: https://reviews.apache.org/r/21151/diff/ > > > Testing > ------- > > > Thanks, > > Lukas Nalezenec > >
