[
https://issues.apache.org/jira/browse/GIRAPH-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076714#comment-14076714
]
Sergey Edunov commented on GIRAPH-927:
--------------------------------------
Hi Craig, I can't reproduce your issue, and everything works within the test
case,
can you please test this patch? I also attached it to the issue
diff --git
giraph-core/src/main/java/org/apache/giraph/comm/messages/queue/AsyncMessageStoreWrapper.java
giraph-core/src/main/java/org/apache/giraph/comm/messages/queue/AsyncMessageStoreWrapper.java
index a62834f..252ee39 100644
---
giraph-core/src/main/java/org/apache/giraph/comm/messages/queue/AsyncMessageStoreWrapper.java
+++
giraph-core/src/main/java/org/apache/giraph/comm/messages/queue/AsyncMessageStoreWrapper.java
@@ -60,7 +60,7 @@ public final class AsyncMessageStoreWrapper<I extends
WritableComparable,
/** Executor that processes messages in background */
private static final ExecutorService EXECUTOR_SERVICE =
Executors.newCachedThreadPool(
- new ThreadFactoryBuilder()
+ new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("AsyncMessageStoreWrapper-%d").build());
/** Number of threads that will process messages in background */
> Decouple netty server threads from message processing
> -----------------------------------------------------
>
> Key: GIRAPH-927
> URL: https://issues.apache.org/jira/browse/GIRAPH-927
> Project: Giraph
> Issue Type: Improvement
> Reporter: Sergey Edunov
> Attachments: GIRAPH-927.patch, async.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Our profiling shows that a lot of apps are neither CPU nor memory or network
> bound. Instead they waste a lot of time waiting for lock in MessageStore.
> That happens in netty threads.
> We should be able to put messages into queue and then process them in other
> set of threads.
> It has to be configurable because adding another thread level will introduce
> additional overhead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
