Martin Junghanns created GIRAPH-962:
---------------------------------------

             Summary: TextAggregatorWriter with frequency AT_THE_END writes in 
every superstep
                 Key: GIRAPH-962
                 URL: https://issues.apache.org/jira/browse/GIRAPH-962
             Project: Giraph
          Issue Type: Bug
          Components: bsp
    Affects Versions: 1.1.0
            Reporter: Martin Junghanns
            Priority: Minor
             Fix For: 1.1.0


TextAggregatorWriter is used to write the content of all aggregators in a 
superstep to a text file. It offers three predefined frequencies:

{{NEVER (0)}}
{{ALWAYS (1) // in each superstep}}
{{AT_THE_END (-1) // only in the last superstep}}

The aggregators are written in a superstep if the following condition evaluates 
to true:

{{(frequeny == AT_THE_END && superstep == LAST_SUPERSTEP) || (frequency != 
NEVER && superstep % frequency == 0)}}

The problem is, that {{LAST_SUPERSTEP}} is represented by {{-1}} and {{x % -1 = 
0}} for all {{x}}. This leads to the case, that if {{frequency = AT_THE_END}}, 
the content is written in every superstep.

On way to solve this is to extend the second part of the OR-clause to 
{{(frequency != NEVER && frequency != AT_THE_END && superstep % frequency == 
0)}}







--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to