[
https://issues.apache.org/jira/browse/GIRAPH-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280650#comment-14280650
]
Hudson commented on GIRAPH-962:
-------------------------------
FAILURE: Integrated in Giraph-trunk-Commit #1518 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/1518/])
GIRAPH-962: TextAggregatorWriter with frequency AT_THE_END writes in every
superstep (mju via majakabiljo) (majakabiljo:
http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=43de1d8cddacf02e48cf6a7ac5a5888369e978cd)
* CHANGELOG
*
giraph-core/src/main/java/org/apache/giraph/aggregators/TextAggregatorWriter.java
> TextAggregatorWriter with frequency AT_THE_END writes in every superstep
> ------------------------------------------------------------------------
>
> Key: GIRAPH-962
> URL: https://issues.apache.org/jira/browse/GIRAPH-962
> Project: Giraph
> Issue Type: Bug
> Components: bsp
> Affects Versions: 1.1.0
> Reporter: Martin Junghanns
> Priority: Minor
> Labels: aggregator, bsp
> Fix For: 1.1.0
>
> Attachments: GIRAPH-962.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> TextAggregatorWriter is used to write the content of all aggregators in a
> superstep to a text file. It offers three predefined frequencies:
> {{NEVER (0)}}
> {{ALWAYS (1) // in each superstep}}
> {{AT_THE_END (-1) // only in the last superstep}}
> The aggregators are written in a superstep if the following condition
> evaluates to true:
> {{(frequeny == AT_THE_END && superstep == LAST_SUPERSTEP) || (frequency !=
> NEVER && superstep % frequency == 0)}}
> The problem is, that {{LAST_SUPERSTEP}} is represented by {{-1}} and {{x % -1
> = 0}} for all {{x}}. This leads to the case, that if {{frequency =
> AT_THE_END}}, the content is written in every superstep.
> On way to solve this is to extend the second part of the OR-clause to
> {{(frequency != NEVER && frequency != AT_THE_END && superstep % frequency ==
> 0)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
