No problem. I will work on yarn profile issue (=GIRAPH-969[^1]) with the assumption that Hadoop 2.7 is the lowest version of YARN we are going to support. I can finish this work by this saturday[^2].
Thanks, Dongjin [^1]: https://issues.apache.org/jira/browse/GIRAPH-969 [^2]: Friday for your timezone - As you know, Seoul is 17 hours ahead of you. :) On Thu, Jun 23, 2016 at 1:31 AM, Roman Shaposhnik <ro...@shaposhnik.org> wrote: > Really great points, Dongjin! > > Sergey, any chance you can help with GIRAPH-882 review? Since this is > outside > of my area of expertise. > > As for the YARN support, may I suggest the following? We start with an > assumption > that Hadoop 2.7 is the lowest version of YARN we are going to support. > Then we close > the JIRAs and update POMs as Dongjin is suggesting. This is an area I > can definitely > help with. Let me know if there's any disagreement. If not -- I'll > proceed according to this > plan on Fri. > > Thanks, > Roman. > > On Wed, Jun 22, 2016 at 8:49 AM, Dongjin Lee <dong...@apache.org> wrote: > > Hello. I submitted a patch for GIRAPH-882[^1] but it seems like omitted > > from the release list. Could you review my patch, please? I updated my > > first patch applying your comments. > > > > Add to this, I have two more issues. > > > > The first one is GIRAPH-981[^2], which is one of two still-open issues. > We > > have to update hadoop_yarn profile to apply the comments by Martella and > > Shaposhnik on GIRAPH-981 (see the final three comments). The related Jira > > issue is GIRAPH-969[^3]. (In the comment Shaposhnik said that he forgot > the > > id.) If it's no inconvenience to you, may I submit the patch of > GIRAPH-969 > > to close GIRAPH-981? I am also the author of the GIRAPH-947 patch which > was > > discussed in the comments of GIRAPH-981. > > > > The second one is GIRAPH-959[^4]. I think this is intended design so not > an > > actual problem. How about close this issue before the release of 1.2.0? > > > > Regards, > > Dongjin > > > > [^1]: https://issues.apache.org/jira/browse/GIRAPH-882 > > [^2]: https://issues.apache.org/jira/browse/GIRAPH-981 > > [^3]: https://issues.apache.org/jira/browse/GIRAPH-969 > > > > On Wed, Jun 22, 2016 at 2:42 AM, Sergey Edunov <edu...@fb.com> wrote: > > > >> Hi! > >> > >> Recently, I talked to Roman and Avery about Giraph release process and > we > >> agreed it needs to be revived. > >> 1.1.0 has been released 1.5 years ago and we had a lot of changes since > >> then. Now is a good time to release 1.2.0. I volunteer to be release > master > >> this time. > >> > >> In this release, we will have new implementation of "Out Of Core", > >> multiple performance and reliability improvements and of course bug > fixes. > >> > >> As of today, one test case fails with memory issues, I’ll be working > with > >> author to figure out the fix. > >> We have two open issues marked for 1.2.0-SNAPSHOT, both have patches > >> available: > >> https://issues.apache.org/jira/browse/GIRAPH-993 > >> https://issues.apache.org/jira/browse/GIRAPH-981 > >> Let's review and close them. > >> > >> > >> Also, please, by Jun 29, reply in this thread if you have something > planed > >> that should go into this release. If there will be no issues by then, > I'll > >> cut a branch and start building and testing new Giraph 1.2.0 > >> > >> Regards, > >> Sergey > >> > >> >
