[ https://issues.apache.org/jira/browse/GIRAPH-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891109#comment-15891109 ]
ASF GitHub Bot commented on GIRAPH-1132: ---------------------------------------- GitHub user edunov opened a pull request: https://github.com/apache/giraph/pull/21 GIRAPH-1132 Giraph jobs don't end if zookeeper dies before job starts I'm not sure I set all the timeouts right. There is no way to test all of these either. The idea is that we shouldn't have infinite wait loops anywhere. And that's exactly what this diff does You can merge this pull request into a Git repository by running: $ git pull https://github.com/edunov/giraph timeout Alternatively you can review and apply these changes as the patch at: https://github.com/apache/giraph/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 ---- commit cdbe7d4a46d80611fb5846eeeab37b94e66781a1 Author: Sergey Edunov <edu...@fb.com> Date: 2017-03-01T21:41:37Z GIRAPH-1132 Giraph jobs don't end if zookeeper dies before job starts ---- > Giraph jobs don't end if zookeeper dies before job starts > --------------------------------------------------------- > > Key: GIRAPH-1132 > URL: https://issues.apache.org/jira/browse/GIRAPH-1132 > Project: Giraph > Issue Type: Bug > Reporter: Sergey Edunov > > There are multiple places in the Giraph code where we waitForever() on some > event (e.g. all workers to finish or zookeeper to come up). This is in > general bad, as any issue on other side may become undetected and make job > run forever. We need to introduce timeout to these waits -- This message was sent by Atlassian JIRA (v6.3.15#6346)