[ 
https://issues.apache.org/jira/browse/GIRAPH-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016535#comment-16016535
 ] 

ASF GitHub Bot commented on GIRAPH-1147:
----------------------------------------

Github user dlogothetis commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/38#discussion_r117364342
  
    --- Diff: 
giraph-core/src/main/java/org/apache/giraph/master/input/MasterInputSplitsHandler.java
 ---
    @@ -56,16 +69,39 @@
       /** Latches to say when one input splits type is ready to be accessed */
       private Map<InputType, CountDownLatch> latchesMap =
           new EnumMap<>(InputType.class);
    +  /** Context for accessing counters */
    +  private final Mapper.Context context;
    +  /** How many splits per type are there total */
    +  private final Map<InputType, Integer> numSplitsPerType =
    +      new EnumMap<>(InputType.class);
    +  /** How many splits per type have been read so far */
    +  private final Map<InputType, AtomicInteger> numSplitsReadPerType =
    +      new EnumMap<>(InputType.class);
    +  /**
    +   * Store in counters timestamps when we finished reading
    +   * these fractions of input
    +   */
    +  private final double[] doneFractionsToStoreInCoutners;
    --- End diff --
    
    Typo in field name.


> Store timestamps when various fractions of input were done
> ----------------------------------------------------------
>
>                 Key: GIRAPH-1147
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1147
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>            Priority: Minor
>
> In order to evaluate how read stragglers affect job performance, add a way to 
> expose timestamps when various fractions of input were done reading through 
> counters.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to