[GitHub] [giraph] atanu1991 commented on a change in pull request #150: GIRAPH-1251: Add optional SSLHandler for all Netty Communication

[GitBox]

atanu1991 commented on a change in pull request #150:
URL: https://github.com/apache/giraph/pull/150#discussion_r635558201



##########
File path: 
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyServer.java
##########
@@ -192,6 +193,12 @@ public NettyServer(ImmutableClassesGiraphConfiguration 
conf,
     } else {
       executionGroup = null;
     }
+
+    if (conf.sslAuthenticate()) {
+      nettySSLHandler = new NettySSLHandler(false, conf);
+    } else {
+      nettySSLHandler = null;
+    }

Review comment:
       Needed as final variable




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org