Thanks Weiting. > is set to *require at least one review approval*
If I understand correctly, we are going to add this restriction back to Apache Gluten repo, is that correct? I think for some trivial PRs committers may want to keep some flexibility to merge by themselves as long as they are confident with the change. But I don't know an easy way to distinguish between trivial and non-trival. So I am +1 to adding the restriction back until we find a better way to make some trade-off. Thanks, Hongze On Wed, Mar 27, 2024 at 10:07 PM WeitingChen <[email protected]> wrote: > Currently, Gluten's Branch Protection rule is null, which means no rule > right now and anyone who has written permission can merge PR. > Many developers from multiple companies highlight this and request to set a > more strict rule. > Before we contribute to Apache the rule is set to *require at least one > review approval* before merging PRs. > Please let me know if there are any comments or just approve this. > > Thanks, > William Chen >
