Thank you for opening this discussion! > I propose to revert PR-5480[2] first to avoid regression.
Would you explain “avoid regression” in more detail? XiDuo You <[email protected]> 于2024年5月31日周五 11:35写道： > Hi folks, > > It is a discussion about PR-5698[1] and PR-5480[2]. I hope the > community can reach an agreement. > > Recently, we are working on fixing the case-class inheritance issue, > thanks to @zhztheplayer, it's great work. However, when touching > `VeloxColumnarWriteFilesExec`, we find it introduces higher cost than > expected. It requires more code and workaround to resolve the issue of > removing case-class inheritance. I think when the cost of solving an > issue exceeds the cost of the issue itself, we can consider tolerating > the known issue. > > I propose to revert PR-5480[2] first to avoid regression. > > Thank you > Xiduo > > [1]: https://github.com/apache/incubator-gluten/pull/5698 > [2]: https://github.com/apache/incubator-gluten/pull/5480 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
