+1 Thanks, Chengcheng
On 2024/07/08 01:54:36 Felix Cheung wrote: > 0 - I'm concerned with some observations in LICENSE. I believe there will be > some comments in the Apache Incubator vote, particularly since the DISCLAIMER > is not using the DISCLAIMER-WIP version. I would strongly recommend changing > to that > https://incubator.apache.org/guides/releasemanagement.html#choice_of_disclaimers > > - incubating in name > - signature and hash fine > - DISCLAIMER is fine > > - LICENSE and NOTICE > > 1. > LICENSE is long and not all license named in there have the source file > identified. Are these all packaged into the source distributions? (See 4) > > 2. > cpp/src/arrow/vendored/base64.cpp what's the source of this? Can the project > not include it in the source form? > > 3. > pandas license, for example, > a. the license should be in the NOTICE file? > b. it requires copyright notice in binary distribution (it should be in the > notice file) > > similar for SSLeay, OpenSSL > > 4. many "3rdparty dependency glog is statically linked in certain binary > distributions" - in those cases, they should not be in LICENSE file. If it is > packaged into binary distributions, then list in the NOTICE in the binary > distribution. > > - unexpected binary files > there are 2 bz2, 1 jar, 1 gz, and other compressed file in the source > distribution. > it might be a better idea to build them instead of package them into the > distribution > - OK- source files have ASF headers > Just to note - Lots of .sql, output, and data files (csv) without ASF header. > - Did not compile from source > > > ________________________________ > From: WeitingChen <[email protected]> > Sent: Sunday, July 7, 2024 5:14 AM > To: [email protected] <[email protected]> > Subject: [VOTE] Release Apache Gluten (Incubating) 1.2.0-RC0 > > Hi all, > > This is a call for a vote to release Apache Gluten (Incubating) version > 1.2.0 release candidate 0. > > The release candidates: > https://dist.apache.org/repos/dist/dev/incubator/gluten/apache-gluten-1.2.0-rc0/ > > Release notes: > https://github.com/apache/incubator-gluten/releases/tag/v1.2.0-rc0 > > Git tag for the release: > https://github.com/apache/incubator-gluten/releases/tag/v1.2.0-rc0 > > Git commit id for the release: > https://github.com/apache/incubator-gluten/commit/c21503548416a596c5403cfbfbd20c4bc8bc5e47 > > Keys to verify the Release Candidate: > https://dist.apache.org/repos/dist/dev/incubator/gluten/KEYS > > The vote will be open for at least 72 hours or until the necessary > number of votes is reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Checklist for reference: > > [ ] Download links are valid. > [ ] Checksums and PGP signatures are valid. > [ ] Source code distributions have correct names matching the current > release. > [ ] LICENSE and NOTICE files are correct for each Apache Gluten repo. > [ ] All files have license headers if necessary. > [ ] No unlicensed compiled archives are bundled in the source archive. > > To compile from the source, please refer to: > https://github.com/apache/incubator-gluten/blob/main/docs/get-started/Velox.md > > Thanks, > Weiting Chen > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
