We may also include the fix: https://github.com/apache/incubator-gluten/pull/6563 to avoid build issues when `build_tests` is enabled.
On Tue, Aug 20, 2024 at 4:59 PM Weiting Chen <[email protected]> wrote: > I would like to cancel this vote to solve the issues address in this > thread. > Will send a RC3 release soon. > Thanks for everyone's vote and comment. > > On 2024/08/15 08:27:52 Kent Yao wrote: > > -1(binding), I have checked: > > > > - Download links are valid > > - Signatures and checksums are fine > > - Incubating in the file names > > - ASF header in source files > > - LICENSE, NOTICE, DISCLAIMER are correct in both source release > > x LICENSE-binary, NOTICE-binary in binary releases should be renamed > > to LICENSE, NOTICE, see [1]. > > x LICENSE and NOTICE in binary releases are better packaged inside the > > jar instead of tgz, as it somehow conflicts with: > > - META-INF/NOTICE.txt, which belongs to Apache Commons Codec > > - META-INF/NOTICE, which belongs to Apache arrow > > - Although the META-INF/LICENSE* files are not conflicting, I > > believe they also originate from upstream sources. > > > > I'd like for you to follow these instructions [2] to exclude the > > NOTICE* and LICENSE* from upstreams and replace them with the ones > > assembled by gluten and its dependencies. You already receive a veto > > for rc1 [3], right? > > > > Some other suggestions: > > > > - The issue [4] for KEYS raised by an IPMC Member is not addressed, > > https://dist.apache.org/repos/dist/dev/incubator/gluten/KEYS > > - PPMC voting for releases SHOULD avoid blind +1, please help verify > > the release and comment on the steps you do in the Checklist > > > > > > Bests, > > Kent Yao > > > > [1] https://infra.apache.org/licensing-howto.html#source-tree-location > > [2] https://infra.apache.org/licensing-howto.html#permissive-deps > > [3] https://lists.apache.org/thread/nv1h2088tgfsnpf5r4ypjyrrpf1y6lb1 > > [4] https://lists.apache.org/thread/wl9nmzn1fynrynotlhqpn5140nzz4sq2 > > > > Biao Liang <[email protected]> 于2024年8月15日周四 12:29写道： > > > > > > +1 > > > > > > philo <[email protected]> 于2024年8月15日周四 10:19写道： > > > > > > > +1. > > > > > > > > Thanks! > > > > > > > > On Wed, Aug 14, 2024 at 10:34 PM WeitingChen <[email protected] > > > > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > This is a call for a vote to release Apache Gluten (Incubating) > version > > > > > 1.2.0 release candidate 2. > > > > > The release candidates: > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/gluten/1.2.0-incubating-rc2 > > > > > Release notes: > > > > > https://github.com/apache/incubator-gluten/releases/tag/v1.2.0-rc2 > > > > > Git tag for the release: > > > > > https://github.com/apache/incubator-gluten/releases/tag/v1.2.0-rc2 > > > > > Git commit ID for the release: > > > > > > > > > > > > > > > https://github.com/apache/incubator-gluten/commit/27e988d70a3a5e365a87d48c481670a4b9ee6b5b > > > > > Keys to verify the Release Candidate: > > > > > https://dist.apache.org/repos/dist/dev/incubator/gluten/KEYS > > > > > > > > > > The vote will be open for at least 72 hours or until the necessary > number > > > > > of votes is reached. Please vote accordingly: > > > > > [ ] +1 approve[ ] +0 no opinion[ ] -1 disapprove with the reason > > > > > Checklist for reference:[ ] Download links are valid.[ ] Checksums > and > > > > PGP > > > > > signatures are valid.[ ] Source code distributions have correct > names > > > > > matching the current release.[ ] LICENSE and NOTICE files are > accurate > > > > for > > > > > each Apache Gluten repo.[ ] All files have license headers if > > > > necessary.[ ] > > > > > No unlicensed compiled archives are bundled in the source archive > > > > > To compile from the source, please refer to: > > > > > > > > > > > > > > > https://github.com/apache/incubator-gluten/blob/main/docs/get-started/Velox.md > > > > > Thanks, Weiting Chen > > > > > > > > > > > > > > > > > > -- > > > from 梁家彪 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
