Hi Feilong,

Thank you for managing this release!

+0

I checked the following:

[✓] Download links are valid.
[✓] Checksums and PGP signatures are valid.
[?] Source code distributions have correct names, matching the current release.

Source code still contains some "1.5.0-SNAPSHOT" version names. They are:

> root@hongze-zhang-VMware20-1:/opt/code/incubator-gluten-2# grep -RFI 
> "1.5.0-SNAPSHOT" ./
> ./gluten-flink/docs/Flink.md:ln -s 
> $GLUTEN_FLINK_HOME/runtime/target/gluten-flink-runtime-1.5.0-SNAPSHOT.jar
> FLINK_HOME/gluten_lib/gluten-flink-runtime-1.5.0.jar
> ./gluten-flink/docs/Flink.md:ln -s 
> $GLUTEN_FLINK_HOME/loader/target/gluten-flink-loader-1.5.0-SNAPSHOT.jar 
> $FLINK_HOME/gluten_lib/gluten-flink-loader-1.5.0.jar
> ./tools/workload/benchmark_velox/tpc_workload.ipynb:    
> "gluten_target_jar='/home/sparkuser/gluten-velox-bundle-spark3.3_2.12-centos_7_x86_64-1.5.0-SNAPSHOT.jar'\n",
> ./tools/workload/benchmark_velox/params.yaml.template:gluten_target_jar: 
> /home/sparkuser/gluten-velox-bundle-spark3.3_2.12-centos_7_x86_64-1.5.0-SNAPSHOT.jar

There are also some "1.3.0-SNAPSHOT"s left over from the previous releases:

> root@hongze-zhang-VMware20-1:/opt/code/incubator-gluten-2# grep -RFI 
> "1.3.0-SNAPSHOT" ./
> ./tools/qualification-tool/README.md:java -jar 
> target/qualification-tool-1.3.0-SNAPSHOT-jar-with-dependencies.jar -f 
> <eventFile>
> ./tools/qualification-tool/README.md:java -jar 
> target/qualification-tool-1.3.0-SNAPSHOT-jar-with-dependencies.jar -f 
> /path/to/eventlog
> ./tools/qualification-tool/README.md:java -jar 
> target/qualification-tool-1.3.0-SNAPSHOT-jar-with-dependencies.jar -f 
> /path/to/folder -o /output/path -t 8 -d 2023-01-01 -k /path/to/gcs_keys.json 
> -p my_project

I'd recommend cleaning them all at once in this release to reduce the
burden for the next one. Let me know what you think.

Thanks,
Hongze

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to