GitHub user zhouyuan added a comment to the discussion: [Discuss] Keep the 
commit history when adding a new spark version

+1 on keep the old commit history.
The same issue exits for unit tests as well.  Apache repo merging behavior is 
controlled by below file and in Gluten we may need to enable `rebase merge`
https://github.com/apache/incubator-gluten/blob/main/.asf.yaml#L35-L37

> My suggestion is for developers to use a merge commit locally to retain the 
> history of all smaller individual commits.

This may be difficult to achieve as we usually amend fixes when addressing the 
review/comments. Using a single commit can keep the git log much cleaner and 
People can always to lookup the changes in GH pull requests 

GitHub link: 
https://github.com/apache/incubator-gluten/discussions/11352#discussioncomment-15407670

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to