[
https://issues.apache.org/jira/browse/GOBBLIN-1234?focusedWorklogId=470900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470900
]
ASF GitHub Bot logged work on GOBBLIN-1234:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/20 21:55
Start Date: 14/Aug/20 21:55
Worklog Time Spent: 10m
Work Description: sv2000 opened a new pull request #3080:
URL: https://github.com/apache/incubator-gobblin/pull/3080
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1234
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
The JobHistoryStore unit tests fail on local build after the MySQL v8 bump
up due to change in default settings for the system variable
explicit_defaults_for_timestamp. This results in a change in how timestamp
columns with NULL values are handled.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Fixed failing unit tests after v8 bump up. So verified existing unit tests
in DatabaseJobHistoryStoreTest.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 470900)
Remaining Estimate: 0h
Time Spent: 10m
> Fix unit tests that fail on local build after MySQL v8 bump up
> --------------------------------------------------------------
>
> Key: GOBBLIN-1234
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1234
> Project: Apache Gobblin
> Issue Type: Bug
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The JobHistoryStore unit tests fail on local build after the MySQL v8 bump up
> due to change in default settings for the system variable
> {{[explicit_defaults_for_timestamp|https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_explicit_defaults_for_timestamp].
> This results in a change in how timestamp columns with NULL values are
> handled. }}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
