[
https://issues.apache.org/jira/browse/GOBBLIN-1241?focusedWorklogId=471743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471743
]
ASF GitHub Bot logged work on GOBBLIN-1241:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/20 00:14
Start Date: 18/Aug/20 00:14
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3083:
URL: https://github.com/apache/incubator-gobblin/pull/3083#discussion_r471842017
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GitFlowGraphMonitor.java
##########
@@ -184,10 +184,13 @@ private void addDataNode(DiffEntry change) {
if (checkFilePath(change.getNewPath(), NODE_FILE_DEPTH)) {
Path nodeFilePath = new Path(this.repositoryDir, change.getNewPath());
try {
- Config config = loadNodeFileWithOverrides(nodeFilePath);
- Class dataNodeClass = Class.forName(ConfigUtils.getString(config,
FlowGraphConfigurationKeys.DATA_NODE_CLASS,
+ // Temporarily resolve the data node config when constructing it, but
leave it unresolved after to allow overriding
+ Config unresolvedConfig = loadNodeFileWithOverrides(nodeFilePath);
+ Config resolvedConfig = unresolvedConfig.resolve();
Review comment:
I would have done that, but for example the fs URI check happens in
`FileSystemDataNode`, not `BaseDataNode`. I did it this way to avoid needing to
add this resolution into the constructor of every child data node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 471743)
Time Spent: 40m (was: 0.5h)
> Allow nodes/edges in HOCON format and delay resolution to allow overriding
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1241
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1241
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
