[
https://issues.apache.org/jira/browse/GOBBLIN-1248?focusedWorklogId=474448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474448
]
ASF GitHub Bot logged work on GOBBLIN-1248:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/20 18:22
Start Date: 25/Aug/20 18:22
Worklog Time Spent: 10m
Work Description: ZihanLi58 opened a new pull request #3091:
URL: https://github.com/apache/incubator-gobblin/pull/3091
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1248
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
**Why this PR?**
Previously in streaming pipeline, to avoid race condition on metadata
schema, when we do hive registration, we always fetch the latest schema from
Kafka SchemaRegistry, since gobblin converter may change the schema, this
introduce discrepancy between hive table schema and real file schema, so we
need a better way to solve this problem
**Solution**
We leverage the schema creation time in the schema fetched from schema
registry adn keep that information when converter the schema. If the schema
creation time of writer's schema is the same as latest schema, we will update
the table schema to the writer's schema, else we will keep the schema same as
existing table's schema
**What's the change**
By default there is no change, to leverage this feature, the pipeline must
be configured to use schema registry V2 to fetch schema which contains
information about schema creation time.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Run streaming pipeline to test hive can works well
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 474448)
Remaining Estimate: 0h
Time Spent: 10m
> Fix discrepancy between table schema and file schema
> ----------------------------------------------------
>
> Key: GOBBLIN-1248
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1248
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Previously in streaming pipeline, to avoid race condition on metadata schema,
> when we do hive registration, we always fetch the latest schema from Kafka
> SchemaRegistry, since gobblin converter may change the schema, this introduce
> discrepancy between hive table schema and real file schema, so we need a
> better way to solve this problem
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
