[
https://issues.apache.org/jira/browse/GOBBLIN-1248?focusedWorklogId=475507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475507
]
ASF GitHub Bot logged work on GOBBLIN-1248:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/20 19:42
Start Date: 27/Aug/20 19:42
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3091:
URL: https://github.com/apache/incubator-gobblin/pull/3091#discussion_r478652534
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -201,15 +201,14 @@ protected void registerPath(HiveSpec spec) throws
IOException {
* existing table.
* Note: If there is no schema specified in the table spec, we will directly
update the schema to
* the existing table schema
- * Note: We treat the creation time as version number of schema, since
according to Kafka team,
- * schema registry allows "out of order registration" of schemas, this means
chronological latest is
- * NOT what the registry considers latest.
+ * Note: We cannot treat the creation time as version number of schema,
since schema registry allows
+ * "out of order registration" of schemas, this means chronological latest
is NOT what the registry considers latest.
* @param spec
* @param table
* @param existingTable
* @throws IOException
*/
- private void updateSchema(HiveSpec spec, Table table, HiveTable
existingTable) throws IOException{
+ protected void updateSchema(HiveSpec spec, Table table, HiveTable
existingTable) throws IOException{
Review comment:
Nit: Would be annotate as VisibleForTesting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 475507)
Time Spent: 2h 10m (was: 2h)
> Fix discrepancy between table schema and file schema
> ----------------------------------------------------
>
> Key: GOBBLIN-1248
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1248
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Previously in streaming pipeline, to avoid race condition on metadata schema,
> when we do hive registration, we always fetch the latest schema from Kafka
> SchemaRegistry, since gobblin converter may change the schema, this introduce
> discrepancy between hive table schema and real file schema, so we need a
> better way to solve this problem
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
