[
https://issues.apache.org/jira/browse/GOBBLIN-1251?focusedWorklogId=475562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475562
]
ASF GitHub Bot logged work on GOBBLIN-1251:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/20 21:54
Start Date: 27/Aug/20 21:54
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3092:
URL: https://github.com/apache/incubator-gobblin/pull/3092#discussion_r478716594
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTaskStateTracker.java
##########
@@ -42,24 +45,39 @@
*
* @author Yinan Li
*/
-@Alpha
+@Slf4j
public class GobblinHelixTaskStateTracker extends AbstractTaskStateTracker {
-
- private static final Logger LOGGER =
LoggerFactory.getLogger(GobblinHelixTaskStateTracker.class);
+ @VisibleForTesting
+ static final String IS_TASK_METRICS_SCHEDULING_FAILURE_FATAl =
"helixTaskTracker.isNewTaskRegFailureFatal";
Review comment:
FATAl -> FATAL.
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTaskStateTracker.java
##########
@@ -42,24 +45,39 @@
*
* @author Yinan Li
*/
-@Alpha
+@Slf4j
public class GobblinHelixTaskStateTracker extends AbstractTaskStateTracker {
-
- private static final Logger LOGGER =
LoggerFactory.getLogger(GobblinHelixTaskStateTracker.class);
+ @VisibleForTesting
+ static final String IS_TASK_METRICS_SCHEDULING_FAILURE_FATAl =
"helixTaskTracker.isNewTaskRegFailureFatal";
+ private static final String DEFAULT_TASK_METRICS_SCHEDULING_FAILURE_FATAl =
"false";
Review comment:
FATAl -> FATAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 475562)
Time Spent: 40m (was: 0.5h)
> Propagate failure from statsTracker scheduling
> ----------------------------------------------
>
> Key: GOBBLIN-1251
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1251
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
