[
https://issues.apache.org/jira/browse/GOBBLIN-1257?focusedWorklogId=479233&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479233
]
ASF GitHub Bot logged work on GOBBLIN-1257:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/20 18:47
Start Date: 04/Sep/20 18:47
Worklog Time Spent: 10m
Work Description: sv2000 opened a new pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097
…chema up-conversion in compaction
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1257
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Currently, on schema change while copying map/list entries from the original
schema into the evolved schema, all the entries in the collection point to the
same reference. This is inadvertently caused by re-using the same
WritableComparable object for all the values. In addition to fixing this issue,
this PR:
1. Refactors/enhances existing unit tests, and
2. Introduces a new convenience class for local testing of the compaction
job and provides a simple way of reproducing compaction issues locally. This
class requires users to provide input data records in json format along with an
input ORC schema. It generates the corresponding input ORC files and runs the
compaction job against the generated input.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added tests to OrcUtilsTest class.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 479233)
Remaining Estimate: 0h
Time Spent: 10m
> Fix the handling of collection field types during ORC schema up-conversion in
> compaction
> ----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1257
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1257
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-compaction
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Issac Buenrostro
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, on schema change while copying map/list entries from the original
> schema into the evolved schema, all the entries in the collection point to
> the same reference. This is inadvertently caused by re-using the same
> WritableComparable object for all the values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
