sv2000 commented on a change in pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097#discussion_r485086038
##########
File path: gobblin-compaction/build.gradle
##########
@@ -31,6 +31,7 @@ dependencies {
// with hive-exec-core in older version(1.0.1), we need to shadow
ord-mapreduce's transitive deps.
// and include direct orc-mapreduce library just as a compileOnly dependency
compileOnly externalDependency.orcMapreduce
+ compile externalDependency.orcTools
Review comment:
Since the utility class that allows users to run compaction locally is
not a unit test, I had it located in the src/main of gobblin-compaction module.
Also, this dependency will be needed at runtime, hence I chose "compile".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]