autumnust commented on a change in pull request #3090: URL: https://github.com/apache/incubator-gobblin/pull/3090#discussion_r485249845
########## File path: gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/AvroOrcSchemaConverter.java ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.writer; + +import java.util.List; +import java.util.stream.Collectors; + +import org.apache.avro.Schema; +import org.apache.orc.TypeDescription; + + +/** + * A utility class that provides a method to convert {@link Schema} into {@link TypeDescription}. + */ +public class AvroOrcSchemaConverter { Review comment: I actually would prefer keeping them in this module - It looks more natural to leave such kind of data-format specific thing in gobblin-module, while gobblin-utility should be more on handling gobblin constructs. Also the ORC dependency will be pretty messy if moving to utility. A big pain is hive version used in gobblin oss and that being used in orc library. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
