sv2000 commented on a change in pull request #3112:
URL: https://github.com/apache/incubator-gobblin/pull/3112#discussion_r495634378
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/ConfigStoreUtils.java
##########
@@ -260,8 +262,11 @@ public static void setTopicsFromConfigStore(Properties
properties, Set<String> b
}
public static List<String> getListOfValuesFromConfigStore(Config config,
String keyValue) {
Review comment:
Doesn't ConfigUtils#getStringList() achieve the same? If so, should we
reuse the method defined there?
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/ConfigStoreUtils.java
##########
@@ -260,8 +262,11 @@ public static void setTopicsFromConfigStore(Properties
properties, Set<String> b
}
public static List<String> getListOfValuesFromConfigStore(Config config,
String keyValue) {
Review comment:
Also - it seems like the more appropriate name of the 2nd argument
should be key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
