[
https://issues.apache.org/jira/browse/GOBBLIN-1286?focusedWorklogId=500077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500077
]
ASF GitHub Bot logged work on GOBBLIN-1286:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/20 14:10
Start Date: 13/Oct/20 14:10
Worklog Time Spent: 10m
Work Description: sandy143651 opened a new pull request #3125:
URL: https://github.com/apache/incubator-gobblin/pull/3125
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
https://issues.apache.org/jira/browse/GOBBLIN-1286
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Changed the method to use
org.apache.hadoop.fs.FileSystem#addDelegationTokens instead of
org.apache.hadoop.fs.FileSystem#getDelegationTokens which makes sure that DTs
for all the child namenodes are also fetched. Note that this change is
backwards-compatible.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
The change is straightforward and doesn't require explicit unit testing.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 500077)
Remaining Estimate: 0h
Time Spent: 10m
> Support fetching multiple DFS tokens for HDFS Federation
> --------------------------------------------------------
>
> Key: GOBBLIN-1286
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1286
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: misc
> Reporter: Sandeep Devaiah
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently org.apache.gobblin.util.hadoop.TokenUtils#getHdfsToken adds the
> DistributedFileSystem's delegation token to the Credential's object. However,
> if the DFS is federated, then only one token for the primary name node is
> fetched and tokens for child namenodes are not fetched.
> Hence this method needs to be updated to use
> org.apache.hadoop.fs.FileSystem#addDelegationTokens instead of
> org.apache.hadoop.fs.FileSystem#getDelegationTokens which automatically
> fetches the delegation tokens for all child FS as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
