sv2000 commented on a change in pull request #3124:
URL: https://github.com/apache/incubator-gobblin/pull/3124#discussion_r504333555
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/FlowStatusGenerator.java
##########
@@ -176,6 +182,9 @@ private boolean isJobRunning(JobStatus jobStatus) {
* Send kill request for the given flow
*/
public void killFlow(String flowGroup, String flowName, Long
flowExecutionId) {
Review comment:
Quick question: Why is there a killFlow() method in FlowStatusGenerator?
Can this method be relocated into FlowExecutionResource which seems like the
right location? Looks like you only want the eventBus instance in
FlowExecutionResource, which can be injected the same way that
FlowStatusGenerator is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
