[
https://issues.apache.org/jira/browse/GOBBLIN-1292?focusedWorklogId=502470&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-502470
]
ASF GitHub Bot logged work on GOBBLIN-1292:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/20 03:03
Start Date: 20/Oct/20 03:03
Worklog Time Spent: 10m
Work Description: shirshanka commented on pull request #3131:
URL:
https://github.com/apache/incubator-gobblin/pull/3131#issuecomment-712557981
@sv2000 : I think the standardization of how temporary directories are
created and how directories from within them are handed out might be useful
refactoring for future test writers. They won't need to remember how to create
a temp directory, how to combine a temp directory with inner directories etc.
I know it seems like a nit, but I think it sets up the "testing harness" in
a better way IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 502470)
Time Spent: 40m (was: 0.5h)
> Undo hardcoded tmp directory locations for unit tests
> -----------------------------------------------------
>
> Key: GOBBLIN-1292
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1292
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: misc
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Several unit tests in Gobblin make use of hardcoded tmp directory locations.
> If these locations are not cleaned up, they have the potential to cause test
> failures in subsequent builds. Further, hardcoded locations may potentially
> collide with other tests which may accidentally use the same location. This
> task modifies a host of tests to use dynamically generated temp directories
> which are automatically cleaned up when tests complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
