[
https://issues.apache.org/jira/browse/GOBBLIN-1300?focusedWorklogId=504334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504334
]
ASF GitHub Bot logged work on GOBBLIN-1300:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/20 21:41
Start Date: 23/Oct/20 21:41
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3138:
URL: https://github.com/apache/incubator-gobblin/pull/3138#discussion_r511167846
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -134,6 +134,8 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
if (jobStatus != null) {
try(Timer.Context context =
getMetricContext().timer(GET_AND_SET_JOB_STATUS).time()) {
addJobStatusToStateStore(jobStatus, this.stateStore);
+ } catch (IOException ioe) {
+ throw new RuntimeException("Failed to add job status to state
store", ioe);
Review comment:
parseJobStatus method can be modified to swallow the IOException. It
seems to be doing that for most part anyways. The IOException being thrown by
readSchemaVersioningInformation can be caught inside the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 504334)
Time Spent: 1h (was: 50m)
> Rethrow exceptions when storing job status in state store
> ---------------------------------------------------------
>
> Key: GOBBLIN-1300
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1300
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
