li-ygerchikov commented on a change in pull request #3139:
URL: https://github.com/apache/incubator-gobblin/pull/3139#discussion_r513787406
##########
File path:
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -175,18 +169,14 @@ public AzkabanJobLauncher(String jobId, Properties props)
this.props
.setProperty(ConfigurationKeys.JOB_TRACKING_URL_KEY,
Strings.nullToEmpty(conf.get(AZKABAN_LINK_JOBEXEC_URL)));
- if (props.containsKey(JOB_TYPE) &&
JOB_TYPES_WITH_AUTOMATIC_TOKEN.contains(props.getProperty(JOB_TYPE))) {
- // Necessary for compatibility with Azkaban's hadoopJava job type
- // http://azkaban.github.io/azkaban/docs/2.5/#hadoopjava-type
- LOG.info(
- "Job type " + props.getProperty(JOB_TYPE) + " provides Hadoop tokens
automatically. Using provided tokens.");
- if (System.getenv(HADOOP_TOKEN_FILE_LOCATION) != null) {
- this.props.setProperty(MAPREDUCE_JOB_CREDENTIALS_BINARY,
System.getenv(HADOOP_TOKEN_FILE_LOCATION));
- }
+ if (System.getenv(HADOOP_TOKEN_FILE_LOCATION) != null) {
Review comment:
Yes, this should work. I just wander if there may be situations when the
env var is set, but the file is either missing or obsolete or does not contain
the right tokens... How much of this could (and is worth) checking? E.g.
checking that the file exists should be fairly trivial.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
