arjun4084346 commented on a change in pull request #3141:
URL: https://github.com/apache/incubator-gobblin/pull/3141#discussion_r513840447
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -535,7 +535,11 @@ public WorkUnit apply(@Nullable WorkUnit input) {
} finally {
try {
TimingEvent jobCleanupTimer =
this.eventSubmitter.getTimingEvent(TimingEvent.LauncherTimings.JOB_CLEANUP);
- cleanupStagingData(jobState);
+ try {
+ cleanupStagingData(jobState);
+ } catch (Throwable t) {
+ LOG.error("Failed to clean up staging data", t);
Review comment:
But this change will swallow the exception and any errors in
`cleanupStagingData` will not fail the job and hence will go undetected (even
if there is log message).
Should we rather move the code we want to run (sending GTEs) to the finally
block at line 600?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
