[
https://issues.apache.org/jira/browse/GOBBLIN-1303?focusedWorklogId=506462&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506462
]
ASF GitHub Bot logged work on GOBBLIN-1303:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/20 23:41
Start Date: 29/Oct/20 23:41
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3141:
URL: https://github.com/apache/incubator-gobblin/pull/3141#discussion_r514628565
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -535,7 +535,11 @@ public WorkUnit apply(@Nullable WorkUnit input) {
} finally {
try {
TimingEvent jobCleanupTimer =
this.eventSubmitter.getTimingEvent(TimingEvent.LauncherTimings.JOB_CLEANUP);
- cleanupStagingData(jobState);
+ try {
+ cleanupStagingData(jobState);
+ } catch (Throwable t) {
+ LOG.error("Failed to clean up staging data", t);
Review comment:
Actually isn't this kind of the normal behaviour for a failed job? Any
exception in work unit creation is caught at line 530 and not rethrown, does
the job not failed for those cases either?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 506462)
Time Spent: 50m (was: 40m)
> Catch error when failing to clean staging data
> ----------------------------------------------
>
> Key: GOBBLIN-1303
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1303
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
