[
https://issues.apache.org/jira/browse/GOBBLIN-1187?focusedWorklogId=511099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-511099
]
ASF GitHub Bot logged work on GOBBLIN-1187:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/20 22:55
Start Date: 12/Nov/20 22:55
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#discussion_r522486541
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -298,24 +296,14 @@ synchronized public void stopDag(URI uri) throws
IOException {
/**
* Add the specified flow to {@link DagManager#cancelQueue}
*/
- private void killFlow(String flowGroup, String flowName, long
flowExecutionId) throws IOException {
+ void killFlow(String flowGroup, String flowName, long flowExecutionId)
throws IOException {
int queueId = DagManagerUtils.getDagQueueId(flowExecutionId,
this.numThreads);
String dagId = DagManagerUtils.generateDagId(flowGroup, flowName,
flowExecutionId);
if (!this.cancelQueue[queueId].offer(dagId)) {
throw new IOException("Could not add dag " + dagId + " to cancellation
queue.");
}
}
- @Subscribe
Review comment:
It is doing that, right? see GobblinServiceManager.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 511099)
Time Spent: 3h 20m (was: 3h 10m)
> cancel a gaas flow when the dag manager is disabled
> ---------------------------------------------------
>
> Key: GOBBLIN-1187
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1187
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
