arjun4084346 commented on a change in pull request #3155:
URL: https://github.com/apache/incubator-gobblin/pull/3155#discussion_r528874276
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallable.java
##########
@@ -334,15 +351,44 @@ private void runJobExecutionLauncher() throws
JobException {
if (startTime != 0) {
this.planningJobLauncherMetrics.updateTimeForFailedPlanningJobs(startTime);
}
- log.error("Failed to run planning job {}", jobName, e);
- throw new JobException("Failed to run planning job " + jobName, e);
+ log.error("Failed to run planning job for {}", this.jobUri, e);
+ throw new JobException("Failed to run planning job for " + this.jobUri,
e);
} finally {
try {
closer.close();
} catch (IOException e) {
- throw new JobException("Cannot properly close planning job " +
jobName, e);
+ throw new JobException("Cannot properly close planning job for " +
this.jobUri, e);
+ }
+ }
+ }
+
+ private boolean canRun(Optional<String> jobIdFromStore, HelixManager
helixManager) throws JobException, InterruptedException {
Review comment:
I just refactored this code to avoid code duplication
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
