[
https://issues.apache.org/jira/browse/GOBBLIN-1323?focusedWorklogId=515784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515784
]
ASF GitHub Bot logged work on GOBBLIN-1323:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/20 22:00
Start Date: 23/Nov/20 22:00
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3156:
URL:
https://github.com/apache/incubator-gobblin/pull/3156#issuecomment-732450924
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3156?src=pr&el=h1)
Report
> Merging
[#3156](https://codecov.io/gh/apache/incubator-gobblin/pull/3156?src=pr&el=desc)
(dda7995) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/f81a2a2ac93091ac878985565bc010532418e2c2?el=desc)
(f81a2a2) will **decrease** coverage by `36.70%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3156 +/- ##
============================================
- Coverage 45.93% 9.22% -36.71%
+ Complexity 9596 1724 -7872
============================================
Files 1997 1997
Lines 76096 76097 +1
Branches 8469 8469
============================================
- Hits 34952 7021 -27931
- Misses 37879 68392 +30513
+ Partials 3265 684 -2581
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3156?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ce/extractor/extract/restapi/RestApiExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9yZXN0YXBpL1Jlc3RBcGlFeHRyYWN0b3IuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
|
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/cluster/SingleHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlSGVsaXhUYXNrLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1048
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3156/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3156?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3156?src=pr&el=footer).
Last update
[f81a2a2...dda7995](https://codecov.io/gh/apache/incubator-gobblin/pull/3156?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 515784)
Time Spent: 20m (was: 10m)
> make columnListInQuery in RestApiExtractor overridable in child class for
> Dynamics Extractor
> --------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1323
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1323
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Wenqin Wang
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Recently we've discovered that in our Dynamics ingestion pipeline, we would
> not remove invalid fields in our query before pulling data for dynamics
> entities, and therefore gobblin ingestion would fail due to field not found
> error. This feature is implemented for Salesforce in RestApiExtrator.java,
> and the logic is specifically tailored for Salesforce. Therefore i'm
> proposing some changes and hope to get Gobblin dev's guidance and reviews.
> For Dynamics, to enable this feature, here is the solution that I think works
> the best:
> since the query looks different from Salesforce query, we need to change the
> way we extract fields from client-specified-query. I will make a protected
> method in RestApiExtractor.java to wrap this Utils.getColumnListFromQuery,
> and override it in DynamicsExtractor.java (the child class) to write specific
> logic for dynamics use case. After that, we can override the buildDataQuery
> method in DynamicsExtractor.java ourselves to replace user-specified-query
> with validated fields. This way it would not affect other extractors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
