Will-Lo commented on a change in pull request #3154: URL: https://github.com/apache/incubator-gobblin/pull/3154#discussion_r536364461
########## File path: gobblin-docker/gobblin-recipes/kafka-hdfs/docker-compose.yml ########## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +version: '3' +services: + gobblin-standalone: + image: apache/gobblin:latest + volumes: + - "${LOCAL_JOB_DIR}:/tmp/gobblin-standalone/jobs" + zookeeper: + image: wurstmeister/zookeeper + ports: + - "2181:2181" + kafka: + image: wurstmeister/kafka + ports: + - "9092:9092" + environment: + KAFKA_ADVERTISED_HOST_NAME: "kafka" + KAFKA_ADVERTISED_PORT: "9092" + KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181 + KAFKA_CREATE_TOPICS: "test:1:1" + volumes: + - /var/run/docker.sock:/var/run/docker.sock + + namenode: + image: bde2020/hadoop-namenode:1.1.0-hadoop2.7.1-java8 + container_name: namenode + volumes: + - hadoop_namenode:/hadoop/dfs/name + environment: + - CLUSTER_NAME=test_cluster + env_file: + - ./hadoop.env + ports: + - "9870:9870" + + resourcemanager: + image: bde2020/hadoop-resourcemanager:1.1.0-hadoop2.7.1-java8 + container_name: resourcemanager + restart: on-failure + depends_on: Review comment: Is `depends_on` needed here? You have `restart: on-failure` which should be sufficient. `depends_on` is deprecated from version 3 onwards so we shouldn't introduce it https://docs.docker.com/compose/compose-file/#depends_on ########## File path: gobblin-docker/gobblin-recipes/kafka-hdfs/docker-compose.yml ########## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +version: '3' +services: + gobblin-standalone: + image: apache/gobblin:latest + volumes: + - "${LOCAL_JOB_DIR}:/tmp/gobblin-standalone/jobs" + zookeeper: + image: wurstmeister/zookeeper + ports: + - "2181:2181" + kafka: Review comment: We should add `restart: on-failure` here in as kafka is dependent on zookeeper so it might terminate if zookeeper takes a while to load up. ########## File path: gobblin-docker/gobblin-recipes/kafka-hdfs/docker-compose.yml ########## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +version: '3' +services: + gobblin-standalone: + image: apache/gobblin:latest + volumes: + - "${LOCAL_JOB_DIR}:/tmp/gobblin-standalone/jobs" + zookeeper: + image: wurstmeister/zookeeper + ports: + - "2181:2181" + kafka: + image: wurstmeister/kafka + ports: + - "9092:9092" + environment: + KAFKA_ADVERTISED_HOST_NAME: "kafka" + KAFKA_ADVERTISED_PORT: "9092" + KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181 + KAFKA_CREATE_TOPICS: "test:1:1" + volumes: + - /var/run/docker.sock:/var/run/docker.sock + + namenode: + image: bde2020/hadoop-namenode:1.1.0-hadoop2.7.1-java8 + container_name: namenode + volumes: + - hadoop_namenode:/hadoop/dfs/name + environment: + - CLUSTER_NAME=test_cluster + env_file: + - ./hadoop.env + ports: + - "9870:9870" + + resourcemanager: + image: bde2020/hadoop-resourcemanager:1.1.0-hadoop2.7.1-java8 + container_name: resourcemanager + restart: on-failure + depends_on: + - namenode + - datanode1 + - datanode2 + - datanode3 + env_file: + - ./hadoop.env + ports: + - "8089:8088" + + historyserver: + image: bde2020/hadoop-historyserver:1.1.0-hadoop2.7.1-java8 + container_name: historyserver + depends_on: + - namenode + - datanode1 + - datanode2 + volumes: + - hadoop_historyserver:/hadoop/yarn/timeline + env_file: + - ./hadoop.env + ports: + - "8188:8188" + + nodemanager1: + image: bde2020/hadoop-nodemanager:1.1.0-hadoop2.7.1-java8 + container_name: nodemanager1 + depends_on: + - namenode + - datanode1 + - datanode2 + env_file: + - ./hadoop.env + ports: + - "8042:8042" + + datanode1: + image: bde2020/hadoop-datanode:1.1.0-hadoop2.7.1-java8 + container_name: datanode1 + depends_on: Review comment: same comment as above, depends_on is deprecated on version 3 which this file is on ########## File path: gobblin-docker/gobblin-recipes/kafka-hdfs/docker-compose.yml ########## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +version: '3' +services: + gobblin-standalone: + image: apache/gobblin:latest + volumes: + - "${LOCAL_JOB_DIR}:/tmp/gobblin-standalone/jobs" + zookeeper: + image: wurstmeister/zookeeper + ports: + - "2181:2181" + kafka: + image: wurstmeister/kafka + ports: + - "9092:9092" + environment: + KAFKA_ADVERTISED_HOST_NAME: "kafka" + KAFKA_ADVERTISED_PORT: "9092" + KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181 + KAFKA_CREATE_TOPICS: "test:1:1" + volumes: + - /var/run/docker.sock:/var/run/docker.sock + + namenode: + image: bde2020/hadoop-namenode:1.1.0-hadoop2.7.1-java8 + container_name: namenode + volumes: + - hadoop_namenode:/hadoop/dfs/name + environment: + - CLUSTER_NAME=test_cluster + env_file: + - ./hadoop.env + ports: + - "9870:9870" + + resourcemanager: + image: bde2020/hadoop-resourcemanager:1.1.0-hadoop2.7.1-java8 + container_name: resourcemanager + restart: on-failure + depends_on: + - namenode + - datanode1 + - datanode2 + - datanode3 + env_file: + - ./hadoop.env + ports: + - "8089:8088" + + historyserver: + image: bde2020/hadoop-historyserver:1.1.0-hadoop2.7.1-java8 + container_name: historyserver + depends_on: + - namenode + - datanode1 + - datanode2 + volumes: + - hadoop_historyserver:/hadoop/yarn/timeline + env_file: + - ./hadoop.env + ports: + - "8188:8188" + + nodemanager1: + image: bde2020/hadoop-nodemanager:1.1.0-hadoop2.7.1-java8 + container_name: nodemanager1 + depends_on: + - namenode + - datanode1 + - datanode2 + env_file: + - ./hadoop.env + ports: + - "8042:8042" + + datanode1: + image: bde2020/hadoop-datanode:1.1.0-hadoop2.7.1-java8 + container_name: datanode1 + depends_on: + - namenode + volumes: + - hadoop_datanode1:/hadoop/dfs/data + env_file: + - ./hadoop.env + + datanode2: + image: bde2020/hadoop-datanode:1.1.0-hadoop2.7.1-java8 + container_name: datanode2 + depends_on: + - namenode + volumes: + - hadoop_datanode2:/hadoop/dfs/data + env_file: + - ./hadoop.env + + datanode3: + image: bde2020/hadoop-datanode:1.1.0-hadoop2.7.1-java8 + container_name: datanode3 + depends_on: Review comment: same comment as above, `depends_on` is deprecated on version 3 which this file is on ########## File path: gobblin-docker/gobblin-recipes/kafka-hdfs/docker-compose.yml ########## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +version: '3' +services: + gobblin-standalone: + image: apache/gobblin:latest + volumes: + - "${LOCAL_JOB_DIR}:/tmp/gobblin-standalone/jobs" + zookeeper: + image: wurstmeister/zookeeper + ports: + - "2181:2181" + kafka: + image: wurstmeister/kafka + ports: + - "9092:9092" + environment: + KAFKA_ADVERTISED_HOST_NAME: "kafka" + KAFKA_ADVERTISED_PORT: "9092" + KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181 + KAFKA_CREATE_TOPICS: "test:1:1" + volumes: + - /var/run/docker.sock:/var/run/docker.sock + + namenode: + image: bde2020/hadoop-namenode:1.1.0-hadoop2.7.1-java8 + container_name: namenode + volumes: + - hadoop_namenode:/hadoop/dfs/name + environment: + - CLUSTER_NAME=test_cluster + env_file: + - ./hadoop.env + ports: + - "9870:9870" + + resourcemanager: + image: bde2020/hadoop-resourcemanager:1.1.0-hadoop2.7.1-java8 + container_name: resourcemanager + restart: on-failure + depends_on: + - namenode + - datanode1 + - datanode2 + - datanode3 + env_file: + - ./hadoop.env + ports: + - "8089:8088" + + historyserver: + image: bde2020/hadoop-historyserver:1.1.0-hadoop2.7.1-java8 + container_name: historyserver + depends_on: + - namenode + - datanode1 + - datanode2 + volumes: + - hadoop_historyserver:/hadoop/yarn/timeline + env_file: + - ./hadoop.env + ports: + - "8188:8188" + + nodemanager1: + image: bde2020/hadoop-nodemanager:1.1.0-hadoop2.7.1-java8 + container_name: nodemanager1 + depends_on: + - namenode + - datanode1 + - datanode2 + env_file: + - ./hadoop.env + ports: + - "8042:8042" + + datanode1: + image: bde2020/hadoop-datanode:1.1.0-hadoop2.7.1-java8 + container_name: datanode1 + depends_on: + - namenode + volumes: + - hadoop_datanode1:/hadoop/dfs/data + env_file: + - ./hadoop.env + + datanode2: + image: bde2020/hadoop-datanode:1.1.0-hadoop2.7.1-java8 + container_name: datanode2 + depends_on: Review comment: same comment as above, depends_on is deprecated on version 3 which this file is on ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
