[
https://issues.apache.org/jira/browse/GOBBLIN-1325?focusedWorklogId=521266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-521266
]
ASF GitHub Bot logged work on GOBBLIN-1325:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/20 16:28
Start Date: 07/Dec/20 16:28
Worklog Time Spent: 10m
Work Description: hanghangliu commented on a change in pull request #3163:
URL: https://github.com/apache/incubator-gobblin/pull/3163#discussion_r537644087
##########
File path:
gobblin-modules/gobblin-kafka-11/src/main/java/org/apache/gobblin/kafka/serialize/LiAvroSerializer.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.kafka.serialize;
+
+import org.apache.avro.generic.GenericRecord;
+import org.apache.kafka.common.errors.SerializationException;
+import org.apache.kafka.common.serialization.Serializer;
+
+
+/**
+ * LinkedIn's implementation of Avro-schema based serialization for Kafka
+ * TODO: Implement this for IndexedRecord not just GenericRecord
+ *
+ */
+public class LiAvroSerializer extends LiAvroSerializerBase implements
Serializer<GenericRecord> {
Review comment:
It's a good idea to deprecate the LI-specific implementations. I'm just
using them during tests.
In the meantime, could you please tell me what avro serde do we normally
use? I couldn't find a better implementation in our codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 521266)
Time Spent: 1.5h (was: 1h 20m)
> Add Kafka 1.1 Module
> --------------------
>
> Key: GOBBLIN-1325
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1325
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-kafka
> Reporter: Hanghang Liu
> Assignee: Shirshanka Das
> Priority: Critical
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Upgrade request got from the Verizon team: Kafka 1.1
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
