[
https://issues.apache.org/jira/browse/GOBBLIN-1338?focusedWorklogId=524307&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524307
]
ASF GitHub Bot logged work on GOBBLIN-1338:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 08:11
Start Date: 15/Dec/20 08:11
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3175:
URL:
https://github.com/apache/incubator-gobblin/pull/3175#issuecomment-745126280
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3175?src=pr&el=h1)
Report
> Merging
[#3175](https://codecov.io/gh/apache/incubator-gobblin/pull/3175?src=pr&el=desc)
(70be13c) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/c002a1baf73b9c23541b22714c375dbbd8a3dd43?el=desc)
(c002a1b) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3175?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3175 +/- ##
===========================================
- Coverage 9.10% 9.10% -0.01%
Complexity 1724 1724
===========================================
Files 2014 2014
Lines 77095 77099 +4
Branches 8559 8559
===========================================
Hits 7021 7021
- Misses 69390 69394 +4
Partials 684 684
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3175?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...n/java/org/apache/gobblin/writer/FsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3175/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Gc0RhdGFXcml0ZXIuamF2YQ==)
| `60.17% <0.00%> (-2.21%)` | `10.00 <0.00> (ø)` | |
|
[...g/apache/gobblin/writer/PartitionedDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3175/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9QYXJ0aXRpb25lZERhdGFXcml0ZXIuamF2YQ==)
| `2.02% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3175?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3175?src=pr&el=footer).
Last update
[c002a1b...70be13c](https://codecov.io/gh/apache/incubator-gobblin/pull/3175?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524307)
Time Spent: 20m (was: 10m)
> Log and suppress exceptions in FsDataWriter.getFinalState
> ---------------------------------------------------------
>
> Key: GOBBLIN-1338
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1338
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> FsDataWriter#getFinalState() sometimes encounters an exception when calling
> recordsWritten(). This can cause other final state values to not be set.
> The exception should be suppressed like is already the case for when
> bytesWritten() is called in this method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
