[
https://issues.apache.org/jira/browse/GOBBLIN-1344?focusedWorklogId=527383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527383
]
ASF GitHub Bot logged work on GOBBLIN-1344:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/20 21:53
Start Date: 22/Dec/20 21:53
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3181:
URL: https://github.com/apache/incubator-gobblin/pull/3181#discussion_r547524434
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -280,8 +291,15 @@ private boolean
ensureHiveTableExistenceBeforeAlternation(String tableName, Stri
try (Timer.Context context =
this.metricContext.timer(GET_HIVE_TABLE).time()) {
existingTable =
HiveMetaStoreUtils.getHiveTable(client.getTable(dbName, tableName));
}
+ HiveTable schemaSourceTable = existingTable;
+ if (state.contains(SCHEMA_SOURCE_DB) ||
state.contains(SCHEMA_SOURCE_TABLE)) {
Review comment:
In both compaction pipeline and ingestion pipeline, this state is topic
specific state. And for this case that db is registered as an additional db,
the db name is specified by a job level config. So I think for all the tables
in this db, it should has the same source db. That's why I do want to make this
config a job level config also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 527383)
Time Spent: 40m (was: 0.5h)
> Enable configurable schema source db and table when registering hive schema
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1344
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1344
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We need to set schema.literal for hive table, but in ORC compaction pipeline,
> there is no context for avro schema. So for de-duped DB which is registered
> by compaction pipeline, we need to be able to configure the schema source
> db/table to get the avro schema registered by data ingestion pipeline
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
