hanghangliu commented on a change in pull request #3185: URL: https://github.com/apache/incubator-gobblin/pull/3185#discussion_r548932673
########## File path: gobblin-docs/user-guide/Docker-Integration.md ########## @@ -12,21 +12,25 @@ For more information on Docker, including how to install it, check out the docum # Docker Repositories -Gobblin currently has four different repositories, and all are on Docker Hub [here](https://hub.docker.com/u/gobblin/). We are also starting to use [Apache's repository](https://hub.docker.com/r/apache/gobblin/tags?page=1&ordering=last_updated) for our images. +Github Actions pushes the latest docker image to the Apache DockerHub repository [here](https://hub.docker.com/r/apache/gobblin) from `gobblin-docker/gobblin/alpine-gobblin-latest/Dockerfile` -The `gobblin/gobblin-wikipedia` repository contains images that run the Gobblin Wikipedia job found in the [getting started guide](../Getting-Started). These images are useful for users new to Docker or Gobblin, they primarily act as a "Hello World" example for the Gobblin Docker integration. +To run this image, you will need to pass in the corresponding execution mode. Review comment: We can add a reference for the execution mode: https://gobblin.readthedocs.io/en/latest/user-guide/Gobblin-Deployment/ or https://github.com/apache/incubator-gobblin/blob/master/gobblin-docs/user-guide/Gobblin-Deployment.md ########## File path: gobblin-docs/user-guide/Docker-Integration.md ########## @@ -94,9 +98,7 @@ Similar to standalone working directory settings: Run these commands to start the docker image: -`docker pull gobblin/gobblin-service:alpine-gaas-latest` - -`docker run -p 6956:6956 -v GAAS_JOB_DIR:/tmp/gobblin-as-service/jobs -v LOCAL_DATAPACK_DIR:/tmp/templateCatalog gobblin/gobblin-service:alpine-gaas-latest` +`docker run -p 6956:6956 -v GAAS_JOB_DIR:/tmp/gobblin-as-service/jobs -v LOCAL_DATAPACK_DIR:/tmp/templateCatalog apache/gobblin --mode gobblin-as-service` Review comment: Need to add $ sign for the directories exports like this: docker run -p 6956:6956 -v $GAAS_JOB_DIR:/tmp/gobblin-as-service/jobs -v $LOCAL_DATAPACK_DIR:/tmp/templateCatalog apache/gobblin --mode gobblin-as-service ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
