aplex commented on a change in pull request #3176:
URL: https://github.com/apache/incubator-gobblin/pull/3176#discussion_r551587674
##########
File path:
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/service/modules/orchestration/AzkabanClient.java
##########
@@ -97,7 +86,8 @@ protected AzkabanClient(String username,
long sessionExpireInMin,
CloseableHttpClient httpClient,
SessionManager sessionManager,
- ExecutorService executorService)
+ ExecutorService executorService,
Review comment:
This is a builder constructor. I don't think it makes sense to have a
backward-compatible overload every time we add a setting here, we'll end up wit
a lot of overloads.
##########
File path:
gobblin-modules/gobblin-azkaban/src/test/java/org/apache/gobblin/service/modules/orchestration/AzkabanClientTest.java
##########
@@ -48,9 +41,14 @@
* Please check https://azkaban.github.io/azkaban/docs/latest/ for how to
setup Azkaban-solo-server.
*/
@Slf4j
+@Test(enabled = false)
Review comment:
All those tests were actually disabled by default, because they require
local Azkaban to be set up. We can look into automatically starting & shutting
it down as a follow up improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
