[
https://issues.apache.org/jira/browse/GOBBLIN-1351?focusedWorklogId=532062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532062
]
ASF GitHub Bot logged work on GOBBLIN-1351:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 18:48
Start Date: 06/Jan/21 18:48
Worklog Time Spent: 10m
Work Description: codecov-io edited a comment on pull request #3190:
URL:
https://github.com/apache/incubator-gobblin/pull/3190#issuecomment-755140299
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=h1)
Report
> Merging
[#3190](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=desc)
(c4d2945) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/b1006b4da3f036cffdb81978faf3f26f3e577f76?el=desc)
(b1006b4) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3190 +/- ##
============================================
+ Coverage 46.18% 46.20% +0.02%
- Complexity 9753 9769 +16
============================================
Files 2014 2016 +2
Lines 77095 77165 +70
Branches 8559 8568 +9
============================================
+ Hits 35606 35657 +51
- Misses 38182 38200 +18
- Partials 3307 3308 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...trumented/extractor/InstrumentedExtractorBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5zdHJ1bWVudGVkL2V4dHJhY3Rvci9JbnN0cnVtZW50ZWRFeHRyYWN0b3JCYXNlLmphdmE=)
| `46.42% <0.00%> (-1.72%)` | `14.00 <0.00> (ø)` | |
|
[...tractor/extract/kafka/KafkaStreamingExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVN0cmVhbWluZ0V4dHJhY3Rvci5qYXZh)
| `58.82% <0.00%> (-1.67%)` | `20.00 <0.00> (ø)` | |
|
[...he/gobblin/source/PartitionAwareFileRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9QYXJ0aXRpb25Bd2FyZUZpbGVSZXRyaWV2ZXIuamF2YQ==)
| `48.14% <0.00%> (-7.41%)` | `0.00% <0.00%> (ø%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
|
[...g/apache/gobblin/writer/PartitionedDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9QYXJ0aXRpb25lZERhdGFXcml0ZXIuamF2YQ==)
| `63.05% <0.00%> (-0.59%)` | `34.00% <0.00%> (ø%)` | |
|
[...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh)
| `10.24% <0.00%> (-0.04%)` | `5.00% <0.00%> (ø%)` | |
|
[...e/gobblin/converter/KafkaSchemaChangeInjector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9LYWZrYVNjaGVtYUNoYW5nZUluamVjdG9yLmphdmE=)
| `87.50% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
|
[...r/GenericRecordBasedKafkaSchemaChangeInjector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9HZW5lcmljUmVjb3JkQmFzZWRLYWZrYVNjaGVtYUNoYW5nZUluamVjdG9yLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
|
[...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=)
| `75.33% <0.00%> (+1.33%)` | `32.00% <0.00%> (+1.00%)` | |
|
[...n/java/org/apache/gobblin/writer/FsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Gc0RhdGFXcml0ZXIuamF2YQ==)
| `76.10% <0.00%> (+6.38%)` | `15.00% <0.00%> (+1.00%)` | |
| ... and [3
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=footer).
Last update
[b1006b4...c4d2945](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532062)
Time Spent: 1h 10m (was: 1h)
> Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1351
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1351
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-kafka
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> KafkaStreamingExtractor extends InstrumentedExtractorBase which currently
> does not invoke the shutdown() method when a task shutdown is requested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
