[
https://issues.apache.org/jira/browse/GOBBLIN-1350?focusedWorklogId=533786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533786
]
ASF GitHub Bot logged work on GOBBLIN-1350:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/21 04:18
Start Date: 10/Jan/21 04:18
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3189:
URL:
https://github.com/apache/incubator-gobblin/pull/3189#issuecomment-757115857
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3189?src=pr&el=h1)
Report
> Merging
[#3189](https://codecov.io/gh/apache/incubator-gobblin/pull/3189?src=pr&el=desc)
(3ee7c1b) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/92fe239355e5c0354a95c2a1ff93e7afc2f53cae?el=desc)
(92fe239) will **decrease** coverage by `36.99%`.
> The diff coverage is `59.66%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3189 +/- ##
============================================
- Coverage 46.19% 9.19% -37.00%
+ Complexity 9721 1737 -7984
============================================
Files 2006 2018 +12
Lines 76856 77287 +431
Branches 8548 8577 +29
============================================
- Hits 35500 7107 -28393
- Misses 38060 69485 +31425
+ Partials 3296 695 -2601
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3189?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../gobblin/runtime/util/JobStateToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Kb2JTdGF0ZVRvSnNvbkNvbnZlcnRlci5qYXZh)
| `32.75% <11.11%> (+12.54%)` | `6.00 <0.00> (ø)` | |
|
[...g/apache/gobblin/runtime/cli/JobStateStoreCLI.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvY2xpL0pvYlN0YXRlU3RvcmVDTEkuamF2YQ==)
| `63.63% <63.63%> (ø)` | `9.00 <9.00> (?)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
|
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1072
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3189/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3189?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3189?src=pr&el=footer).
Last update
[92fe239...3ee7c1b](https://codecov.io/gh/apache/incubator-gobblin/pull/3189?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 533786)
Time Spent: 1.5h (was: 1h 20m)
> Extend Gobblin State Store CLI to show deletes and fix script to properly
> invoke CLI tool
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1350
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1350
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> - Prior CLI script could not instantiate the state store CLI due to parameter
> mismatch
> - Rewrites the CLI to consolidate the different execution modes better, clean
> up code
> - Adds delete functionality to job state based on file input
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
