sv2000 commented on a change in pull request #3200:
URL: https://github.com/apache/incubator-gobblin/pull/3200#discussion_r557032962
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -227,7 +227,10 @@ public void
consumeRecordStream(RecordStreamWithMetadata<D, S> stream)
r.ack();
}
- }, e -> logger.error("Failed to process record.", e),
+ }, e -> {
+ logger.error("Failed to process record.", e);
+ throw((Exception) e);
Review comment:
Sorry - I did not realize earlier that e is a throwable, in which case I
now understand why you had to wrap it into a RuntimeException. I think that
would be better than casting to an Exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
